Commit Graph

871 Commits

Author SHA1 Message Date
Kartik K. Agaram 9fb8f25030 indent 2022-07-08 15:43:45 -07:00
Kartik K. Agaram 00c64ed6e4 add args to some functions
- Text.in_line
2022-07-08 15:37:09 -07:00
Kartik K. Agaram a27dd15c1f add args to some functions
- Text.clip_selection
  - Text.cut_selection
  - Text.delete_selection
  - Text.delete_selection_without_undo
  - Text.mouse_pos
  - Text.to_pos
2022-07-08 15:30:10 -07:00
Kartik K. Agaram 0853a030ac add args to some functions
- Text.pageup
  - Text.pagedown
  - Text.up
  - Text.down
  - Text.end_of_line
  - Text.word_left
  - Text.word_right
  - Text.left
  - Text.right
2022-07-08 15:17:12 -07:00
Kartik K. Agaram e39269b19e start passing left/right margins everywhere
I have a set of changes that passes all tests, but I'm going to commit
them very carefully to ensure I don't miss any call-sites. In this
commit I'm adding the args to:
  - Text.draw
  - Text.tweak_screen_top_and_cursor

But calls within them don't yet pass them where they should. In this
manner I'm going to progress systematically from the top down.
2022-07-08 15:12:17 -07:00
Kartik K. Agaram 8efdb898c6 rename a couple of variables 2022-07-08 14:18:23 -07:00
Kartik K. Agaram 6667c37066 affirm a priority 2022-07-08 14:16:55 -07:00
Kartik K. Agaram 048b6d9d3a drop an arg from a function 2022-07-08 09:44:49 -07:00
Kartik K. Agaram cff1e58cf6 switch arg for a function 2022-07-08 09:44:49 -07:00
Kartik K. Agaram 50a57d7ef6 stop scanning from start of file on every App.draw 2022-07-07 21:51:06 -07:00
Kartik K. Agaram 6dfe954c02 yet another bugfix in selection management
Thanks Leonard Schütz for the report!

Failing scenario:
  click to move cursor
  hit backspace

First backspace wasn't being doing anything earlier.
2022-07-07 07:39:01 -07:00
Kartik K. Agaram dff4587219 just keep the cursor visible after any input events
This is much nicer.
2022-07-06 09:03:54 -07:00
Kartik K. Agaram 2973324ef6 show cursor immediately after a mouse click
I've been subtly finding myself waiting for the cursor to stop blinking
to see if I clicked on the right place.
2022-07-06 08:57:45 -07:00
Kartik K. Agaram 8d00da889d better error message
https://tildegit.org/akkartik/lines.love/issues/1
2022-07-05 14:02:52 -07:00
Kartik K. Agaram 26a98d027b make freehand drawings smoother
Now I might actually use them more, and maybe I can start considering
taking out some shapes. Do I really need circles if I don't provide
ellipses?

Thanks Ivan Reese for the feedback. "What drawings does your tool
encourage?"

Minor note: taking out the deepcopy creates a cute little string like
effect, where the curve grows tighter the slower you draw it.
2022-07-05 11:38:08 -07:00
Kartik K. Agaram 4575648c12 optimization: moving cursor to next word 2022-07-05 11:27:41 -07:00
Kartik K. Agaram f2e5c4ffee bugfix: avoid scrolling on 'end'
There's multiple ways to do this, only one of them is right, and I keep
forgetting what it is. Turn it into a method.
2022-07-05 11:27:23 -07:00
Kartik K. Agaram 3422d92a00 bugfix: 'escape' to cancel a stroke
This has been broken since commit b544e8c357 on May 17 :/
I'm just undoing that commit, which turns out to be completely
unnecessary. And adding a test.
2022-07-05 11:06:55 -07:00
Kartik K. Agaram 3197bb5739 what should happen to selection while drawing?
First idea: just leave it alone. Let's see how this works.
2022-07-05 10:09:51 -07:00
Kartik K. Agaram 18aa21d0c0 keep online help inside of drawing 2022-07-04 22:01:57 -07:00
Kartik K. Agaram ea40a9b661 bugfix
Gracefully degrade if previously edited file shrinks.
2022-07-03 21:03:52 -07:00
Kartik K. Agaram 826207a54a link to export tool 2022-07-02 15:23:44 -07:00
Kartik K. Agaram df5b7a8245 deemphasize the terminal in Readme 2022-07-01 20:34:13 -07:00
Kartik K. Agaram 9fd82439ec drop stale flag from documentation 2022-07-01 20:28:05 -07:00
Kartik K. Agaram 53c35241fb ugh, handle absolute as well as relative paths 2022-07-01 13:56:17 -07:00
Kartik K. Agaram f311013200 include CWD when saving filename 2022-07-01 12:31:23 -07:00
Kartik K. Agaram 914d9c6f98 bugfix: clicking on empty lines 2022-07-01 12:16:43 -07:00
Kartik K. Agaram 79df3da04b enforce press/release state only processed once
bugfix scenario:
  press pageup
  click somewhere near the bottom

Before this change the selection was flickering when doing this.
2022-07-01 11:42:54 -07:00
Kartik K. Agaram e839c3036a bugfix: manage screen_top and cursor when resizing 2022-07-01 11:01:20 -07:00
Kartik K. Agaram 37c5ab87ec bugfix: enable resize when loading settings 2022-06-30 23:02:24 -07:00
Kartik K. Agaram 429a42eb1c right margin 2022-06-30 22:54:34 -07:00
Kartik K. Agaram da3f6c65b3 start loading settings as applicable 2022-06-30 22:46:45 -07:00
Kartik K. Agaram b40dab67f2 start saving some settings to disk on quit
We're still not reading them anywhere.
2022-06-30 22:20:16 -07:00
Kartik K. Agaram 2025172e52 initialize screen width to something reasonable 2022-06-30 22:04:27 -07:00
Kartik K. Agaram 0cd678581b rip out geometry commandline arg
Let's try really hard to ignore the terminal.
2022-06-30 22:02:31 -07:00
Kartik K. Agaram 86cef33630 use the background color
I'd hoped this would reduce the blocks of black while resizing, but it
doesn't seem to have made a difference.
2022-06-30 21:59:17 -07:00
Kartik K. Agaram e1a49c216e stop blanking screen while resizing 2022-06-30 21:56:21 -07:00
Kartik K. Agaram 8c7bea8f76 rip out notion of Line_width 2022-06-30 19:50:27 -07:00
Kartik K. Agaram 08a50b7fff rip out the line-width slider
New plan:
  - render text across the whole window
  - let people resize the window to the desired line width
  - save window size settings between sessions
2022-06-30 19:36:37 -07:00
Kartik K. Agaram 510b0d1dc3 bugfix: lines that aren't drawn from the start
I can't believe I didn't catch this until now. All I had to do is open
MobyDick.markdown from https://www.hogbaysoftware.com/posts/moby-dick-workout,
press page-down and click on the top screen line (or any screen line
containing the same line as the top screen line). Easy to catch with any
file containing lots of overly long lines, as happens in particular at
the start of Moby Dick.

I _had_ seen this problem before, but it seemed to disappear after
unrelated changes, and I convinced myself I'd fixed it as a side-effect.
The bug just failed to manifest if the top line happened to start at the
top of the screen. Scroll down a few pages in Moby Dick and the dialogue
starts and line length drops precipitously.
2022-06-30 18:14:48 -07:00
Kartik K. Agaram 98fa46bf99 some redundant calls 2022-06-30 17:44:31 -07:00
Kartik K. Agaram d009390cc4 bugfix: save previous file when dropping a new one on 2022-06-29 17:58:58 -07:00
Kartik K. Agaram bfbe73e0ef new test: dragging and dropping a file on lines.love 2022-06-29 17:52:40 -07:00
Kartik K. Agaram 9410cccb08 avoid redundant writes on exit 2022-06-29 17:36:56 -07:00
Kartik K. Agaram feba7bf3c2 clarify what "large files" means 2022-06-29 17:34:44 -07:00
Kartik K. Agaram ea4aa0999c clicking to the right of a line within line width 2022-06-29 09:30:23 -07:00
Kartik K. Agaram d07a336131 . 2022-06-29 09:17:38 -07:00
Kartik K. Agaram 8d3adfa36d bugfix: clicking past end of screen line
I could swear I checked this at some point. But I didn't have a test!
2022-06-29 09:17:38 -07:00
Kartik K. Agaram b49ff8dde9 bugfix: scrolling in left/right movements
I'd always had a funny feeling there was something missing there but
somehow never thought of the right failing test.
2022-06-28 18:48:59 -07:00
Kartik K. Agaram 938e3ca1bb when naming points, allow backspacing back to '' 2022-06-27 17:36:10 -07:00