Kartik K. Agaram
bfbe73e0ef
new test: dragging and dropping a file on lines.love
2022-06-29 17:52:40 -07:00
Kartik K. Agaram
9410cccb08
avoid redundant writes on exit
2022-06-29 17:36:56 -07:00
Kartik K. Agaram
feba7bf3c2
clarify what "large files" means
2022-06-29 17:34:44 -07:00
Kartik K. Agaram
ea4aa0999c
clicking to the right of a line within line width
2022-06-29 09:30:23 -07:00
Kartik K. Agaram
d07a336131
.
2022-06-29 09:17:38 -07:00
Kartik K. Agaram
8d3adfa36d
bugfix: clicking past end of screen line
...
I could swear I checked this at some point. But I didn't have a test!
2022-06-29 09:17:38 -07:00
Kartik K. Agaram
b49ff8dde9
bugfix: scrolling in left/right movements
...
I'd always had a funny feeling there was something missing there but
somehow never thought of the right failing test.
2022-06-28 18:48:59 -07:00
Kartik K. Agaram
938e3ca1bb
when naming points, allow backspacing back to ''
2022-06-27 17:36:10 -07:00
Kartik K. Agaram
e63878897e
undo commit 861c57b533
...
Turns out ctrl+ makes it into lua.textinput. Thanks John Blommers for
the report. This should fix https://github.com/akkartik/lines.love/issues/6 .
2022-06-27 17:32:52 -07:00
Kartik K. Agaram
83ba9e61d1
bugfix: typing a capital letter deletes selection
2022-06-26 17:07:27 -07:00
Kartik K. Agaram
44fb3ecd55
bugfix: deleting a selection spanning pages
2022-06-26 16:34:06 -07:00
Kartik K. Agaram
2233066409
bugfix: clear selection in a couple more places
2022-06-23 12:06:44 -07:00
Kartik K. Agaram
84875f3c43
bugfix: don't delete selection when moving cursor
2022-06-23 12:05:36 -07:00
Kartik K. Agaram
da9d948615
record one more case I can't automatically detect
2022-06-23 11:41:29 -07:00
Kartik K. Agaram
cb99ac300c
fix a failing test
...
I deployed this without even running it once :/ Production was broken
for 9 minutes until I rolled back.
2022-06-23 11:40:00 -07:00
Kartik K. Agaram
009c7abb60
extract a function
2022-06-23 11:09:49 -07:00
Kartik K. Agaram
5a06c1286d
bugfix: recompute screen lines in backspace/delete
...
Scenario: backspacing until a line takes up fewer screen lines, then
pressing `down`.
I've gone through and checked that fragments and screen_line_starting_pos
are now cleared together everywhere.
2022-06-23 11:03:46 -07:00
Kartik K. Agaram
515dad95f9
keep drawings within the line width slider as well
2022-06-22 21:08:17 -07:00
Kartik K. Agaram
39913ddbb8
show the line width when dragging the slider
2022-06-22 18:00:53 -07:00
Kartik K. Agaram
54eefbbf2d
turns out super- chords to get to textinput
2022-06-22 17:37:26 -07:00
Kartik K. Agaram
8e68c699f5
bugfix: delete selection before pasting
2022-06-21 09:56:04 -07:00
Kartik K. Agaram
9c8285bf08
bugfix
...
State changes when inserting return are now in sync with other
characters.
2022-06-21 07:24:44 -07:00
Kartik K. Agaram
5a0b6c6a58
better fix for commit 3ffc2ed8f
...
I'm giving up finding a more generalized solution. The issue is that we
need the correct selection state right up to the point where we modify
Lines, in order to capture precise undo state.
Hopefully there aren't any other keychords that should clear the
selection.
2022-06-20 13:30:54 -07:00
Kartik K. Agaram
0d1e6aacd9
revert selection logic to before commit 3ffc2ed8f
...
We still have a failing test, but now it's the one we introduced in
commit 3ffc2ed8f
.
2022-06-20 13:12:29 -07:00
Kartik K. Agaram
978c143397
snapshot: test for a new regression
...
Caused by commit 3ffc2ed8f
.
We might need to bring back a lot of complexity for this.
2022-06-20 12:12:09 -07:00
Kartik K. Agaram
7508a70ed5
selection bugfix
2022-06-20 12:02:51 -07:00
Kartik K. Agaram
c1b6bac187
much simpler
...
We just need to ensure textinput events never make use of selection
state.
All tests are passing, but I'm aware of a couple of issues. But now we
can keep all the special cases in one place.
2022-06-20 11:58:26 -07:00
Kartik K. Agaram
861c57b533
some early returns should be asserts
2022-06-20 11:51:07 -07:00
Kartik K. Agaram
809dae205d
move Selection1 clearing past business logic
...
Now all the cases that clear Selection1 do so in a very consistent way
at the end of each case. And cases that set Selection1 symmetrically do
so at the start of each case.
2022-06-20 11:35:27 -07:00
Kartik K. Agaram
d90617ee24
remove some redundant checks
...
Now all the cases manage Selection1 similarly.
2022-06-20 11:33:04 -07:00
Kartik K. Agaram
3986e99fe0
no, that's not right
...
Bugfix: we want selections to persist even when we lift up the shift
key.
This requires hoisting some code inside every case inside the whole
keypress hierarchy, to ensure we never clear selections before
textinput events can handle them.
Current cross-cutting concerns we're explicitly scattering code for.
- autosave
- undo
- selection management
2022-06-20 11:31:14 -07:00
Kartik K. Agaram
3be413602a
bugfix: typing should delete highlighted text
...
The test harness now also mimics real usage more precisely.
2022-06-20 10:48:35 -07:00
Kartik K. Agaram
9aa7577446
clearer copy
2022-06-20 08:24:56 -07:00
Kartik K. Agaram
3ffc2ed8f3
bugfix
...
To reproduce:
click to position cursor at end of a line
hit enter
press any key
before:
newline got erased and key got added to previous line
now:
newline is preserved
The new test checks a generalization of this.
2022-06-19 09:21:32 -07:00
Kartik K. Agaram
703ed905c1
bugfix: crash in Text.up() after return
...
Let's just make all the utf8.offset calculations more defensive.
2022-06-19 09:06:41 -07:00
Kartik K. Agaram
b6fa2aae6e
typos
2022-06-19 02:40:02 -07:00
Kartik K. Agaram
8d4d00d1e1
fix help for rectangles and squares
...
Thanks John Blommers (https://github.com/akkartik/lines.love/issues/1#issuecomment-1159582457 )
2022-06-18 17:01:44 -07:00
Kartik K. Agaram
2a26a260bb
make sure to save right when quitting
...
I just noticed a few characters missing from one of my notes.
2022-06-18 16:26:45 -07:00
Kartik K. Agaram
c15ee0b4a0
correct location of the line width slider
2022-06-18 00:03:19 -07:00
Kartik K. Agaram
97bbc7da7f
clean up
2022-06-17 23:16:49 -07:00
Kartik K. Agaram
0248339898
more precise shape selection
...
It's important that the error be additive rather than multiplicative,
otherwise the area grows asymmetrically along a line.
Hopefully freehand drawings will work more intuitively now.
2022-06-17 23:15:09 -07:00
Kartik K. Agaram
26995dd62e
correct commit f3abc2cbf2
...
I can't be trusted to do anything without a test.
This should fix #5 . Please reopen if it doesn't.
2022-06-17 22:53:05 -07:00
Kartik K. Agaram
1ecc3f43e5
drop last couple of manual tests
2022-06-17 22:24:46 -07:00
Kartik K. Agaram
b8e8ac2481
manual test for adjusting line width
2022-06-17 22:00:30 -07:00
Kartik K. Agaram
680224bbbc
.
2022-06-17 21:59:05 -07:00
Kartik K. Agaram
f3abc2cbf2
better handle moving points
...
This should hopefully address #5 . I'm removing some constraints from
manhattan lines, rectangles and squares.
2022-06-17 21:40:59 -07:00
Kartik K. Agaram
efbbdfc586
affordance to adjust width for word wrap
2022-06-17 21:36:07 -07:00
Kartik K. Agaram
0fb98d2ac9
indent
2022-06-17 20:08:18 -07:00
Kartik K. Agaram
856c51212a
autosave slightly less aggressively
...
It might reduce wear and tear on disk, and losing 3 seconds of data
doesn't feel catastrophic (short of a C-z rampage).
Thanks to the love2d.org community for the suggestion:
https://love2d.org/forums/viewtopic.php?f=14&t=93173
2022-06-17 15:43:31 -07:00
Kartik K. Agaram
482d07778d
document one more shortcut
2022-06-17 10:28:25 -07:00