akkartik
/
pothi.love
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
pothi.love/0030-update_editor_box

19 lines
704 B
Plaintext
Raw Normal View History

greatly simplify layout I don't know why this was so hard, but I don't need this variable preserve_screen_top_of_cursor_node at all. We only set it when the cursor is in some node, but we also only check for when the current node is the cursor. Comparing with a nil cursor node works just as well. I've also checked that driver.love doesn't need preserve_screen_top_of_cursor_node. I think it came from pensieve.love, where I've since taken it out. Did I ever need it even there?
2023-10-21 17:54:12 +01:00
update_editor_box = function(node)
remove some unnecessary work Let's see if this makes things less sluggish. Before this a surface with just 4 definitions (few 10s of LoC in 3 of them) was sluggish.
2023-01-03 11:15:03 +00:00
if node.editor == nil then return end
let's see if this is easier to understand in 6 mos I spent 4 days agonizing over a bug in driver.love, working up the courage to think about it, and then a whole day trying to make sense of scrolling and deeply questioning my right to tell anyone anything about programming.
2023-10-23 03:50:08 +01:00
if node.y > Viewport.y then
greatly simplify layout I don't know why this was so hard, but I don't need this variable preserve_screen_top_of_cursor_node at all. We only set it when the cursor is in some node, but we also only check for when the current node is the cursor. Comparing with a nil cursor node works just as well. I've also checked that driver.love doesn't need preserve_screen_top_of_cursor_node. I think it came from pensieve.love, where I've since taken it out. Did I ever need it even there?
2023-10-21 17:54:12 +01:00
if node ~= Cursor_node then
remove some unnecessary work Let's see if this makes things less sluggish. Before this a surface with just 4 definitions (few 10s of LoC in 3 of them) was sluggish.
2023-01-03 11:15:03 +00:00
node.editor.screen_top1.line = 1
node.editor.screen_top1.pos = 1
end
node.editor.top = vy(node.y)
else
let's see if this is easier to understand in 6 mos I spent 4 days agonizing over a bug in driver.love, working up the courage to think about it, and then a whole day trying to make sense of scrolling and deeply questioning my right to tell anyone anything about programming.
2023-10-23 03:50:08 +01:00
node.editor.screen_top1, node.editor.top = schema1_of_y(node.editor, scale(Viewport.y-node.y)) -- scale y because editor's font is scaled
bugfix scenario: definition extends above and below viewport position cursor at bottom of viewport press down arrow Before this commit, the viewport would sometimes not scroll, and the cursor would go out of view. I spent 4 days agonizing over this and working up the courage to think about it, then a whole day trying to make sense of scrolling and deeply questioning my right to tell anyone anything about programming, and it's too early to say I _understand_ this fix. Regardless, it seems clear that the interplay between edit.lua and update_editor_box and schema1_to_y is deeply subtle and likely hiding more bugs. There's still one open issue: definition starts halfway down the viewport and extends down below viewport position cursor at bottom of viewport press down arrow The surface jarringly scrolls way more than it needs to just to keep the cursor in view. And I'm terrified to try to fix this. Then again, perhaps I should try to port over bring_cursor_of_cursor_pane_in_view from pensieve.love. That might get rid of this abyss.
2023-10-23 03:39:54 +01:00
node.editor.top = node.editor.top + Menu_bar_height
remove some unnecessary work Let's see if this makes things less sluggish. Before this a surface with just 4 definitions (few 10s of LoC in 3 of them) was sluggish.
2023-01-03 11:15:03 +00:00
end
regression: revert commit d54fc8ec3a I don't follow why luaML doesn't need this, but driver does. Scenario: press ctrl+- repeatedly Before this commit text was overflowing boxes.
2023-05-01 06:36:09 +01:00
if node.editor.font_height ~= scale(20) then
edit.update_font_settings(node.editor, scale(20))
end
new fork: pothi Second attempt based on driver.love
2023-06-18 19:16:02 +01:00
node.editor.left = math.floor(vx(node.x))
remove some unnecessary work Let's see if this makes things less sluggish. Before this a surface with just 4 definitions (few 10s of LoC in 3 of them) was sluggish.
2023-01-03 11:15:03 +00:00
node.editor.right = math.ceil(vx(node.x+node.w))
indent
2023-04-23 06:21:42 +01:00
node.editor.width = node.editor.right - node.editor.left
start rendering file picker on the surface as well This will make things more consistent in the long term, but I realize one major cost: our button abstraction doesn't work well with luaML and compute_layout. So we need something to replace it.
2023-06-22 06:22:13 +01:00
end