akkartik
/
pothi.love
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
pothi.love/0030-update_editor_box

20 lines
686 B
Plaintext
Raw Normal View History

snapshot: a cleaner organization scenarios: * Zoom = 1 * pan with mouse: ✓ * pan with up arrow: ✓ * pan with down arrow: ✓ * Zoom < 1 * pan with mouse: ✓ * pan with up arrow: ✓ * pan with down arrow: ✗ * Zoom > 1 * pan with mouse: ✓ * pan with up arrow: ✗ * pan with down arrow: ✓ What ✓ means: * pan with mouse: lines don't slide relative to the surface * will still slide relative to the surface when zooming in/out; that's unavoidable because we want integer pixels for crisp text * pan with keyboard: at least some part of cursor is always peeking within the viewport * might still look ugly, with the line containing the cursor almost invisible, but hitting the down arrow will never pan upwards, or vice versa Still not working though. I'm pretty much guaranteeing by construction that if Viewport.y was set from screen_top1, then screen_top1 will not be perturbed. And yet using scale() inside update_editor_box is incorrect. Hmm..
2023-10-26 00:46:03 +01:00
update_editor_box = function(node, skip_updating_screen_top_for)
clean up some debug prints
2022-12-26 00:56:47 +00:00
if node.editor == nil then return end
snapshot: insight Ugh, it's been in front of my eyes all along. The logs have been repeatedly showing a recurrence within a single frame: key press -> update Viewport.y from screen_top -> A -> B -> update_editor_box -> update screen_top from Viewport.y We need both those updates, but both should never occur at the same time to the same node. I think this is why screen panning works if I take out the scale inside update_editor_box: the scale has already happened "once" in updating Viewport.y, and it doesn't converge if we perform it a second time in a frame. But the solution is just to do one or the other to a node, never both. I knew this (learned it the hard way) when I first built pensieve.love, and I had an assertion to avoid it. But my assertion was brittle, and it kept failing, and I took it out, and then I slowly took out all the code that prevented this recurrence.
2023-10-26 00:14:08 +01:00
edit.update_font_settings(node.editor, scale(20))
still more wisdom encoded in my old code All tests seem to be passing now. One asymmetry: I'm setting node.editor.top in one branch but not the other. Let's see if that comes back to bite us..
2023-10-26 02:05:38 +01:00
if node.y > Viewport.y then
if node ~= skip_updating_screen_top_for then
clean up some debug prints
2022-12-26 00:56:47 +00:00
node.editor.screen_top1.line = 1
node.editor.screen_top1.pos = 1
still more wisdom encoded in my old code All tests seem to be passing now. One asymmetry: I'm setting node.editor.top in one branch but not the other. Let's see if that comes back to bite us..
2023-10-26 02:05:38 +01:00
end
node.editor.top = vy(node.y)
else
if node ~= skip_updating_screen_top_for then
snapshot: a cleaner organization scenarios: * Zoom = 1 * pan with mouse: ✓ * pan with up arrow: ✓ * pan with down arrow: ✓ * Zoom < 1 * pan with mouse: ✓ * pan with up arrow: ✓ * pan with down arrow: ✗ * Zoom > 1 * pan with mouse: ✓ * pan with up arrow: ✗ * pan with down arrow: ✓ What ✓ means: * pan with mouse: lines don't slide relative to the surface * will still slide relative to the surface when zooming in/out; that's unavoidable because we want integer pixels for crisp text * pan with keyboard: at least some part of cursor is always peeking within the viewport * might still look ugly, with the line containing the cursor almost invisible, but hitting the down arrow will never pan upwards, or vice versa Still not working though. I'm pretty much guaranteeing by construction that if Viewport.y was set from screen_top1, then screen_top1 will not be perturbed. And yet using scale() inside update_editor_box is incorrect. Hmm..
2023-10-26 00:46:03 +01:00
node.editor.screen_top1, node.editor.top = schema1_of_y(node.editor, scale(Viewport.y-node.y))
clean up some debug prints
2022-12-26 00:56:47 +00:00
end
bugfix: size text/box when changing zoom This is a backport from driver.love
2023-04-23 06:27:30 +01:00
end
clean up some debug prints
2022-12-26 00:56:47 +00:00
node.editor.left = math.floor(vx(node.x))
node.editor.right = math.ceil(vx(node.x+node.w))
bugfix: size text/box when changing zoom This is a backport from driver.love
2023-04-23 06:27:30 +01:00
node.editor.width = node.editor.right - node.editor.left
clean up some debug prints
2022-12-26 00:56:47 +00:00
Text.redraw_all(node.editor)
revert commit 4c8960b5c7 Well, almost. I'm just reminding myself of the sort of plumbing I need, not reintroducing the old logic that never worked right and had undergone n iterations of corruption.
2023-10-26 00:21:32 +01:00
end