From c064f0a97df56c28d9d76a226ce152d97e40450a Mon Sep 17 00:00:00 2001
From: "Kartik K. Agaram" <vc@akkartik.com>
Date: Mon, 8 Jul 2024 14:10:49 -0700
Subject: [PATCH] delete some seemingly redundant code

We're patching line_cache and then immediately clearing it using
Text.redraw_all.
---
 edit.lua        |  1 -
 source_edit.lua |  1 -
 source_undo.lua | 11 -----------
 undo.lua        | 11 -----------
 4 files changed, 24 deletions(-)

diff --git a/edit.lua b/edit.lua
index 8424a9b..69756b7 100644
--- a/edit.lua
+++ b/edit.lua
@@ -440,7 +440,6 @@ function edit.keychord_press(State, chord, key)
       State.cursor1 = deepcopy(src.cursor)
       State.selection1 = deepcopy(src.selection)
       patch(State.lines, event.after, event.before)
-      patch_placeholders(State.line_cache, event.after, event.before)
       -- invalidate various cached bits of lines
       State.lines.current_drawing = nil
       Text.redraw_all(State)  -- if we're scrolling, reclaim all line caches to avoid memory leaks
diff --git a/source_edit.lua b/source_edit.lua
index 9b3b7ba..fd8e321 100644
--- a/source_edit.lua
+++ b/source_edit.lua
@@ -441,7 +441,6 @@ function edit.keychord_press(State, chord, key)
       State.cursor1 = deepcopy(src.cursor)
       State.selection1 = deepcopy(src.selection)
       patch(State.lines, event.after, event.before)
-      patch_placeholders(State.line_cache, event.after, event.before)
       -- invalidate various cached bits of lines
       State.lines.current_drawing = nil
       Text.redraw_all(State)  -- if we're scrolling, reclaim all line caches to avoid memory leaks
diff --git a/source_undo.lua b/source_undo.lua
index 8f21a9c..d91fecd 100644
--- a/source_undo.lua
+++ b/source_undo.lua
@@ -81,17 +81,6 @@ function patch(lines, from, to)
   end
 end
 
-function patch_placeholders(line_cache, from, to)
-  assert(from.start_line == to.start_line, 'failed to patch undo operation')
-  for i=from.end_line,from.start_line,-1 do
-    table.remove(line_cache, i)
-  end
-  assert(#to.lines == to.end_line-to.start_line+1, 'failed to patch undo operation')
-  for i=1,#to.lines do
-    table.insert(line_cache, to.start_line+i-1, {})
-  end
-end
-
 -- https://stackoverflow.com/questions/640642/how-do-you-copy-a-lua-table-by-value/26367080#26367080
 function deepcopy(obj, seen)
   if type(obj) ~= 'table' then return obj end
diff --git a/undo.lua b/undo.lua
index 8f21a9c..d91fecd 100644
--- a/undo.lua
+++ b/undo.lua
@@ -81,17 +81,6 @@ function patch(lines, from, to)
   end
 end
 
-function patch_placeholders(line_cache, from, to)
-  assert(from.start_line == to.start_line, 'failed to patch undo operation')
-  for i=from.end_line,from.start_line,-1 do
-    table.remove(line_cache, i)
-  end
-  assert(#to.lines == to.end_line-to.start_line+1, 'failed to patch undo operation')
-  for i=1,#to.lines do
-    table.insert(line_cache, to.start_line+i-1, {})
-  end
-end
-
 -- https://stackoverflow.com/questions/640642/how-do-you-copy-a-lua-table-by-value/26367080#26367080
 function deepcopy(obj, seen)
   if type(obj) ~= 'table' then return obj end