sokoban.love/0015-on.key_release

on.key_release = function(key, scancode)
	if Show_code then
		if Current_pane.editor_state.cursor_x then
			edit.key_release(Current_pane.editor_state, key, scancode)
		end
	else
		if car.key_release then
			call_protected(car.key_release, key, scancode)
		end
		if car.keyreleased then
			call_protected(car.keyreleased, key, scancode)
		end
	end
end
new fork: carousel shell 2023-11-15 14:06:56 +00:00			`on.key_release = function(key, scancode)`
support event handlers I've agonized over conflicts between editor and script handlers for a while, but finally the solution occurred to me: to use the script's handlers, hide the editor. To use the editor's handlers, show the editor. The menu and settings are always active. This seems nice and consistent, easy to explain. Mike Stein would prefer we just supported love.* handlers in scripts to minimize special cases and cognitive load for people. But I'd rather err on the side of being transparent about what's going on inside. As a compromise I'm supporting love.* names at least in addition to my rephrasings (which came about mostly because love.keychordpressed is just too much of a mouthful) 2023-11-22 03:17:49 +00:00			`if Show_code then`
			`if Current_pane.editor_state.cursor_x then`
			`edit.key_release(Current_pane.editor_state, key, scancode)`
			`end`
			`else`
send errors from event handlers to output editor 2023-11-22 05:10:38 +00:00			`if car.key_release then`
			`call_protected(car.key_release, key, scancode)`
			`end`
			`if car.keyreleased then`
			`call_protected(car.keyreleased, key, scancode)`
			`end`
get rid of an assertion It's easy for cursor to go off viewport, and that seems fine. Just don't let a cursor off screen receive keys. 2023-11-20 18:26:14 +00:00			`end`
new fork: carousel shell 2023-11-15 14:06:56 +00:00			`end`