Commit Graph

1320 Commits

Author SHA1 Message Date
Kartik K. Agaram 04540f2fd0 Merge text0 2023-09-08 14:58:54 -07:00
Kartik K. Agaram dab97e2deb Merge text.love 2023-09-08 14:56:57 -07:00
Kartik K. Agaram cb3787048c Merge lines.love 2023-09-08 14:52:40 -07:00
Kartik K. Agaram 87ea2af2da a few more testable file-system operations 2023-09-08 14:03:40 -07:00
Kartik K. Agaram 7cfca844f3 Merge text0 2023-09-04 15:32:12 -07:00
Kartik K. Agaram e71406fede Merge text.love 2023-09-04 15:30:36 -07:00
Kartik K. Agaram 529857ad73 Merge lines.love 2023-09-04 15:22:10 -07:00
Kartik K. Agaram e74b92b733 show any error after switching to source editor
Error_message is a special global. It's set when the app (Current_app = 'run')
encounters an error and switches to the source editor, and cleared when
switching from source editor back to the app.
2023-09-04 15:07:54 -07:00
Kartik K. Agaram ce0b127296 Merge text0 2023-09-04 14:17:04 -07:00
Kartik K. Agaram 4551f06837 Merge text.love 2023-09-04 14:10:09 -07:00
Kartik K. Agaram f41513e718 Merge lines.love 2023-09-04 14:03:34 -07:00
Kartik K. Agaram adfe94b9fc switch to source editor on error
If we're already in source editor we'll quit as before.

It's ugly that app.lua now knows about run.lua. But it's a start.
2023-09-04 13:07:53 -07:00
Kartik K. Agaram 99495355b4 stop using keyboard.isDown
It doesn't work on Android, and it's not much work to avoid.
2023-09-04 00:22:31 -07:00
Kartik K. Agaram 83b8664619 fix a bad merge 2023-08-31 07:23:45 -07:00
Kartik K. Agaram f2eb3b7302 Merge text0 2023-08-31 00:20:30 -07:00
Kartik K. Agaram 921e0fe2c7 Merge text.love 2023-08-31 00:19:45 -07:00
Kartik K. Agaram 5021298090 Merge lines.love 2023-08-31 00:13:43 -07:00
Kartik K. Agaram 6e54ad55d9 yet another set of bugfixes
The key API change I'd underestimated: opening a file used to return nil
on failure, and now returns false.
2023-08-30 23:52:25 -07:00
Kartik K. Agaram bdab8b1c7e Merge text0 2023-08-30 22:58:21 -07:00
Kartik K. Agaram 8439944681 Merge text.love 2023-08-30 22:55:27 -07:00
Kartik K. Agaram 1fc11feb28 Merge lines.love 2023-08-30 22:45:37 -07:00
Kartik K. Agaram 06ad5c4e8c bugfix in source editor
We now need to explicitly select the directory we want to read from.
2023-08-30 22:30:20 -07:00
Kartik K. Agaram f82c0de502 cleaner API for file-system access
Thanks to physfs and nativefs.lua

nativefs still introduces some inconsistencies with love.filesystem with
relative paths:

  * love.fs.read: reads from save dir if it exists, falls back to source dir if not
  * nativefs.read: reads from save dir if it exists, falls back to source dir if not ✓

  * love.fs.write: always writes to save dir
  * nativefs.write: always writes to source dir (since no restrictions)

  * love.fs.newFile followed by file:open('r'): reads from save dir if it exists, source dir if not
  * nativefs.newFile followed by file:open('r'): always reads from working dir

  * love.fs.newFile followed by file:open('w'): always writes to save dir
  * nativefs.newFile followed by file:open('w'): always writes to working dir

So avoid using relative paths with App primitives.
2023-08-30 19:04:06 -07:00
Kartik K. Agaram 7e97a2a1e7 make a few names consistent with snake_case 2023-08-30 06:44:54 -07:00
Kartik K. Agaram 1759c089d7 Merge text0 2023-08-26 16:16:21 -07:00
Kartik K. Agaram e7085e1e17 Merge text.love 2023-08-26 16:04:20 -07:00
Kartik K. Agaram e1fcd7c9c3 Merge lines.love 2023-08-26 15:47:27 -07:00
Kartik K. Agaram ca4ad8a9e5 reorganize app.lua and its comments
I was so sure my comments were clear when I wrote this a year ago. They
were shit. So, most probably, is the current iteration. Feedback
appreciated.
2023-08-26 15:15:42 -07:00
Kartik K. Agaram 9c38e505a5 correct various names in this and other pre-freewheeling forks 2023-08-26 13:15:32 -07:00
Kartik K. Agaram d76541dec3 fix method name in documentation 2023-08-26 13:04:39 -07:00
Kartik K. Agaram 8603ca5d39 tweak wording in test list 2023-08-07 06:52:25 -07:00
Kartik K. Agaram ffa8c4041a bugfix: bring back an accidentally deleted line
Caused by a bad merge in commit 5622e523c.

Thanks Myte#5310 on Discord.
2023-08-05 00:09:04 -07:00
Kartik K. Agaram 3865fd86cd delete an unused arg 2023-07-31 14:20:53 -07:00
Kartik K. Agaram 6a644f3e44 bugfix: render text in given fg color 2023-07-31 12:01:18 -07:00
Kartik K. Agaram 47dd4a6785 Merge text0 2023-07-31 11:08:52 -07:00
Kartik K. Agaram e8a90c616d Merge text.love 2023-07-31 10:59:28 -07:00
Kartik K. Agaram 3b88c6540d Merge lines.love 2023-07-31 10:26:19 -07:00
Kartik K. Agaram b93c0cd6cc reorganize some comments
This keeps things consistent with other forks (links, lines-and-links)
that are "conceptually upstream" of the source editor.
2023-07-31 09:27:31 -07:00
Kartik K. Agaram bb3e12eb5f bugfix: search highlight straddling screen lines 2023-07-31 09:15:48 -07:00
Kartik K. Agaram 2b52383e18 remove a duplicate print to screen
In addition to being more efficient, this will simplify the next bugfix.
2023-07-31 08:56:20 -07:00
Kartik K. Agaram 8879fd6f29 extract a variable 2023-07-31 08:49:24 -07:00
Kartik K. Agaram d6c06db97a bugfix: highlight search patterns on the right line
scenario:
* position a wrapped line on screen
* search for the word immediately after the point of wrapping

Before this commit the word would be highlighted twice:
  - at the end of the first screen line
  - at the start of the second screen line

Now it shows up at the right place.
2023-07-31 08:40:22 -07:00
Kartik K. Agaram f7f42b0bef hoist and duplicate a conditional
I'm duplicating the bounds check when drawing cursor and search
highlight because they're separate concerns and require subtly different
logic.
2023-07-31 08:40:07 -07:00
Kartik K. Agaram 484b76f5c6 improve a comment 2023-07-31 08:21:38 -07:00
Kartik K. Agaram c7e26e656b ignore long (block) comments when selecting buffer name
I asked on the lua-l mailing list, and this seems like the cleanest
approach.
2023-07-25 15:36:11 -07:00
Kartik K. Agaram f23ed15fd9 avoid some unnecessary allocations
To find the first word we currently strip _all_ Lua comments. This is
really wasteful for large definitions. At least avoid all these
allocations if the first word is not a comment.
2023-07-24 00:44:34 -07:00
Kartik K. Agaram 5cac6d8584 handle messages that are all comment 2023-07-24 00:40:34 -07:00
Kartik K. Agaram d16eba699f don't tolerate Lua comments when parsing commands
We only care about Lua comments when the message doesn't start with a
command.
2023-07-24 00:28:24 -07:00
Kartik K. Agaram 6679c6e545 ignore comments when selecting buffer name 2023-07-23 22:32:36 -07:00
Kartik K. Agaram 5622e523c3 Merge text0 2023-07-11 11:15:46 -07:00