akkartik
/
pothi.love
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
pothi.love/0030-update_editor_box

23 lines
872 B
Plaintext
Raw Normal View History

snapshot: a cleaner organization scenarios: * Zoom = 1 * pan with mouse: ✓ * pan with up arrow: ✓ * pan with down arrow: ✓ * Zoom < 1 * pan with mouse: ✓ * pan with up arrow: ✓ * pan with down arrow: ✗ * Zoom > 1 * pan with mouse: ✓ * pan with up arrow: ✗ * pan with down arrow: ✓ What ✓ means: * pan with mouse: lines don't slide relative to the surface * will still slide relative to the surface when zooming in/out; that's unavoidable because we want integer pixels for crisp text * pan with keyboard: at least some part of cursor is always peeking within the viewport * might still look ugly, with the line containing the cursor almost invisible, but hitting the down arrow will never pan upwards, or vice versa Still not working though. I'm pretty much guaranteeing by construction that if Viewport.y was set from screen_top1, then screen_top1 will not be perturbed. And yet using scale() inside update_editor_box is incorrect. Hmm..
2023-10-26 00:46:03 +01:00
update_editor_box = function(node, skip_updating_screen_top_for)
remove some unnecessary work Let's see if this makes things less sluggish. Before this a surface with just 4 definitions (few 10s of LoC in 3 of them) was sluggish.
2023-01-03 11:15:03 +00:00
if node.editor == nil then return end
Merge luaML.love
2023-10-26 05:25:08 +01:00
if node.editor.font_height ~= scale(20) then
edit.update_font_settings(node.editor, scale(20))
end
node.editor.left = math.floor(vx(node.x)) + Line_number_width*App.width('m')
move some related lines closer together
2023-10-26 05:17:00 +01:00
node.editor.right = math.ceil(vx(node.x+node.w))
node.editor.width = node.editor.right - node.editor.left
Text.redraw_all(node.editor)
let's see if this is easier to understand in 6 mos I spent 4 days agonizing over a bug in driver.love, working up the courage to think about it, and then a whole day trying to make sense of scrolling and deeply questioning my right to tell anyone anything about programming.
2023-10-23 03:50:08 +01:00
if node.y > Viewport.y then
still more wisdom encoded in my old code All tests seem to be passing now. One asymmetry: I'm setting node.editor.top in one branch but not the other. Let's see if that comes back to bite us..
2023-10-26 02:05:38 +01:00
if node ~= skip_updating_screen_top_for then
remove some unnecessary work Let's see if this makes things less sluggish. Before this a surface with just 4 definitions (few 10s of LoC in 3 of them) was sluggish.
2023-01-03 11:15:03 +00:00
node.editor.screen_top1.line = 1
node.editor.screen_top1.pos = 1
end
node.editor.top = vy(node.y)
else
still more wisdom encoded in my old code All tests seem to be passing now. One asymmetry: I'm setting node.editor.top in one branch but not the other. Let's see if that comes back to bite us..
2023-10-26 02:05:38 +01:00
if node ~= skip_updating_screen_top_for then
Merge luaML.love
2023-10-26 04:05:50 +01:00
node.editor.screen_top1, node.editor.top = schema1_of_y(node.editor, scale(Viewport.y-node.y)) -- scale y because editor's font is scaled
node.editor.top = node.editor.top + Menu_bar_height
clean up some debug prints
2022-12-26 00:56:47 +00:00
end
remove some unnecessary work Let's see if this makes things less sluggish. Before this a surface with just 4 definitions (few 10s of LoC in 3 of them) was sluggish.
2023-01-03 11:15:03 +00:00
end
Merge luaML.love This one was hard until I realized I'm relying more on editor.width, and have to remember to keep it up to date.
2023-04-03 01:10:21 +01:00
end